Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No SQL escaping for aliases while creating a pack #39

Closed
kozalosev opened this issue Mar 22, 2023 · 1 comment · Fixed by #41
Closed

No SQL escaping for aliases while creating a pack #39

kozalosev opened this issue Mar 22, 2023 · 1 comment · Fixed by #41
Assignees
@kozalosev
Labels
bug Something isn't working
Milestone
v0.3

Comments

@kozalosev
Copy link
Owner

There is no escaping in database/sql: golang/go#18478
So:

SadBot, [22.03.2023 13:40]
it's gone
lost life savings
stonks
not stonks

Favorites Bot, [22.03.2023 13:40]
При создание набора произошла ошибка, попробуйте позже или напишите @kozalo

SadBot, [22.03.2023 13:43]
msg="ERROR: syntax error at or near "s" (SQLSTATE 42601)"
@kozalosev kozalosev added the bug Something isn't working label Mar 22, 2023
@kozalosev kozalosev added this to the v0.3 milestone Mar 22, 2023
@kozalosev kozalosev self-assigned this Mar 22, 2023
@kozalosev kozalosev moved this to Todo in SadFavBot Mar 22, 2023
@kozalosev kozalosev moved this from Todo to In Progress in SadFavBot Mar 22, 2023
@kozalosev
Copy link
Owner Author

Okay, I was wrong. Actually database/sql does the escaping. It was my mistake at one place

@kozalosev kozalosev changed the title No SQL escaping for inserting values No SQL escaping for aliases while creating a pack Mar 22, 2023
kozalosev pushed a commit that referenced this issue Mar 22, 2023
Fix #39 — No SQL escaping for aliases while creating a pack
1b13146
@kozalosev kozalosev mentioned this issue Mar 22, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in SadFavBot Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kozalosev kozalosev

Labels
bug Something isn't working
Projects
SadFavBot
Status: Done
Milestone
v0.3
Development

Successfully merging a pull request may close this issue.

Fix for v0.3.0 kozalosev/SadFavBot
1 participant
@kozalosev