Refactoring, add Kotlin Notebook #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 13, 2024 09:15
Included a new setting in .editorconfig to ignore ktlint function naming rules for functions annotated with @test. This will help in keeping test functions with descriptive names without triggering lint warnings.
Reorganized imports by changing package paths from `dev.langchain4j` to `me.kpavlov.langchain4j.kotlin`. Applied consistent formatting to improve code readability. No functional changes were made.
Refactor project structure by renaming all occurrences of langchain4j-core-kotlin to langchain4j-kotlin. This includes updates to file paths, Maven POM files, and module references to ensure consistency and clarity in the project hierarchy.
Integrated Finchly and JUnit dependencies to improve testing capabilities. Refactored TestEnvironment to utilize Finchly's BaseTestEnvironment for better environment variable handling. Updated tests to leverage the new TestEnvironment setup.
Include configuration for external dependencies in IntelliJ IDEA project. Update .editorconfig to standardize XML file indentation across the project.
kpavlov
added
documentation
Updated the artifactId in the dependency examples within README.md from 'langchain4j-core-kotlin' to 'langchain4j-kotlin'. This ensures consistency with the actual naming conventions used in the project.
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Removed explicit slf4j version in dependency. Updated Makefile and README with lint commands. Enhanced pom.xml with project metadata and linting profile.
added 3 commits
November 13, 2024 10:37
dotenv-kotlin dependency was removed to clean up unused dependencies. This change helps in reducing the build complexity and potential maintenance issues arising from redundant library versions.
This commit introduces a Jupyter notebook set up for LangChain4j in Kotlin, including dependencies and a simple demonstration of generating a joke using OpenAiChatModel. The notebook aims to provide a starting point for users to experiment with LangChain4j's capabilities in a Kotlin environment.
Revised the joke text to include Langchain4j and modified its punchline for better context. Adjusted the timestamps and execution counts of certain cells to reflect the latest execution time and sequence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve code consistency, add new features, and clean up the repository. The most important changes include the renaming of modules, updates to documentation, addition of linting tools, and removal of outdated test files.
Module Renaming:
langchain4j-core-kotlinmodule tolangchain4j-kotlinand updated references inpom.xmland source files accordingly. [1] [2] [3] [4]Documentation Updates:
README.mdto reflect the new artifact ID for Maven and Gradle dependencies. Also, added instructions for running linting before submitting changes. [1] [2] [3]Linting Tools:
.editorconfigsettings for XML files and Kotlin specific settings.Makefileand added external dependencies for linting in.idea/externalDependencies.xml. [1] [2]Test Files Cleanup:
New Features:
langchain4j-kotlinto demonstrate usage examples.