Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved logging #114

Merged
merged 4 commits into from
Dec 13, 2021
Merged

Improved logging #114

merged 4 commits into from
Dec 13, 2021

Conversation

kpcyrd
Copy link
Owner

@kpcyrd kpcyrd commented Dec 12, 2021

Instead of returning a string with the build log this now creates a Vec<u8> and passes it as &mut Vec<u8>, in case of any error (even after we've already logged output from the child process) we append to this Vec too and send it back to the daemon, so the build log up to that point isn't lost.

We also include the following info in logs now:

  • the size limit, if reached
  • the time limit, if reached
  • the human readable error, if any, instead of just rebuilderd: unexpected error while rebuilding package

@kpcyrd kpcyrd merged commit 1ed23f8 into main Dec 13, 2021
@kpcyrd kpcyrd deleted the improved-logging branch December 13, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant