Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 issue with split #20

Closed
stockholmux opened this issue Sep 4, 2013 · 1 comment
Closed

IE8 issue with split #20

stockholmux opened this issue Sep 4, 2013 · 1 comment

Comments

@stockholmux
Copy link

Hi-
In my recent project I noticed that, while the code executed in IE8, the resulting string from JsDiff.applyPatch was scrambled. I was able to work around the issue by using Steven Levithan's polyfill for split ( http://blog.stevenlevithan.com/archives/cross-browser-split ). The way the variable 'meh' in applyPatch is being used isn't supported in IE8. I wouldn't use the polyfill in all situations as it seems to be slower in some cases.

@kpdecker
Copy link
Owner

@stockholmux do you have examples of the failure? Do you still see it under the latest with #24 integrated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants