Skip to content

Turn strict mode on by default in parsePatch #456

Closed
@ExplodingCabbage

Description

@ExplodingCabbage

Currently, if you pass a patch as a string to applyPatch and it has incorrect line counts in the hunk headers, we'll fail to apply it but won't throw an error to tell you that the patch itself was invalid. That seems bad; I spent a long time struggling to figure out why a patch wasn't applying in #238 because of this.

I don't really see any reason for strict mode not to be on by default, and suggest we make it so in the next major version.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions