Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the current package content of 4.0.1 there are some not relevant files included. For example there is a 270 kB yarn-error.log or the .vscode folder:
This could be solved by adding these to the .npmignore. But the package.json files entry seems to be a much better solution here.
Using
npm pack
its possible to view the package content:I am not sure if the .js files in the root folder are needed in production, currently I assume they are not needed in the package.
The
release-notes.md
will be missing out too. I can add this to the 'files' entry if wished.CONTRIBUTING.md
does not seem appropriate in the packaged files.Unrelated: with using the
CONTRIBUTING.md
instructions I do not get thedist/diff.min.js
file. This file is missing in mynpm pack
run too.