Feat: Add exports map for Native ESM
#293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoilti
approved these changes
Aug 12, 2020
calebeby
reviewed
Aug 13, 2020
| }, { | ||
| format: 'esm', | ||
| file: pkg['exports']['.'].import | ||
| } |
There was a problem hiding this comment.
@lukeed What is the advantage of having two separate ESM builds and output files?
There was a problem hiding this comment.
Two things:
-
I'm primarily preserving
diff's existing output files, so that anyone who was import/requiring into the module (eg,require('diff/lib/index.es6.js')) doesn't find a surprise. -
I did not add
"type": "module"(nor do I want to) since that'd be a breaking change. Without that, need.mjsextension for ESM to be activated.
|
Hey thanks for merge :) Any idea when next release will happen? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #292
Used the "loose" variant so that this won't be accidentally breaking for users who are spelunking into the
distorlibdirectories for specific file(s).There's an issue with Node 13.0 through 13.6 that shipped early, now-deprecated versions of the
exportsmap syntax.Any users on those versions should have already abandoned them, since any odd major release (especially early versions of it) are always experimental.
The current
exportsmap works in all 12.x and 14.x versions (and 13.7+).It's completely ignored by older versions of Node since they don't know what it is.
While completely unrelated, I also added the
unpkgkey so that developers can do this, if they want: