Particlenet support for ragged batching #9
Conversation
…ns of configuration files
Particlenet ragged test
| if (igroup < numParticleGroups_) { | ||
| entry_target = std::clamp(static_cast<unsigned int>(((*tag_infos)[jet_n]).features().get("pfcand_etarel").size()), minPartFromJSON, maxPartFromJSON); | ||
| if (toSkipInference && ((*tag_infos)[jet_n]).features().get("pfcand_etarel").size() > 0) toSkipInference = false; | ||
| } else { | ||
| entry_target = std::clamp(static_cast<unsigned int>(((*tag_infos)[jet_n]).features().get("sv_etarel").size()), minVertFromJSON, maxVertFromJSON); | ||
| if (toSkipInference && ((*tag_infos)[jet_n]).features().get("sv_etarel").size() > 0) toSkipInference = false; | ||
| } |
There was a problem hiding this comment.
could reduce duplication here:
std::string entry_feature = (igroup < numParticleGroups_) ? "pfcand_etarel" : "sv_etarel";
entry_target = std::clamp(static_cast<unsigned int>(((*tag_infos)[jet_n]).features().get(entry_feature).size()), minPartFromJSON, maxPartFromJSON);
if (toSkipInference && ((*tag_infos)[jet_n]).features().get(entry_feature).size() > 0) toSkipInference = false;although actually I'm not sure I entirely understand the logic: this block is inside if (igroup == 0) and constexpr static unsigned numParticleGroups_ = 3;, so isn't the else here impossible?
There was a problem hiding this comment.
Yes, I'll look into this.
I'll have to make some changes here (it says can't set batch_size to 0 when ragged batching is enabled for the other event file).
There was a problem hiding this comment.
it says can't set batch_size to 0 when ragged batching is enabled
This is most likely a flaw in my implementation of the interface. I'll try to correct it soon.
|
can you update the PR description with the link to the corresponding model repository that has the ragged models? |
|
Added Model repository link to the PR. |
Geometry/HGCalCommonData/data/dd4hep/cms-test-ddhgcalwafer8-algorithm.xml
Outdated
Show resolved
Hide resolved
Particlenet: