Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .clone() for performance gain #25

Open
kper opened this issue Jul 2, 2020 · 0 comments
Open

Remove .clone() for performance gain #25

kper opened this issue Jul 2, 2020 · 0 comments

Comments

@kper
Copy link
Owner

kper commented Jul 2, 2020

I've ran perf and identified this clone as expensive performance loss.

funky/src/engine.rs

Line 824 in 3e0705e

let f = &self.module.borrow().code[idx as usize].clone();

kper added a commit that referenced this issue Jul 2, 2020
@kper
Fixing #25
27432f8
@kper kper closed this as completed Jul 2, 2020
@kper kper reopened this Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kper