Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automating applications #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

RootenberG
Copy link
Member

@RootenberG RootenberG commented Apr 11, 2019

Closes #5

@RootenberG RootenberG requested a review from webknjaz April 11, 2019 17:05
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/inventory Outdated Show resolved Hide resolved
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep Ansible content in the root of the repository as it'll be the main thing anyway and we'll remove shell scripts.

ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
ansible/install-apps.yml Outdated Show resolved Hide resolved
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, rm unnecessary stat task

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ansible/install-apps.yml Outdated Show resolved Hide resolved
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stat is still unnecessary

@webknjaz
Copy link
Member

plz put ansible content in the root of the repo, also put the apps list into a variable and remove parts of sh scripts which are already ported.
Also, start practicing kpi-web-guild/django-girls-blog-RootenberG#5 on this branch as well.

@webknjaz
Copy link
Member

bump

inventory Outdated
@@ -0,0 +1,3 @@
[target]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be more specific here. Also it's a group so maybe plural is appropriate.
[dev-machines]

inventory Outdated
@@ -0,0 +1,3 @@
[dev-machines]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz add another inventory file with the same group and localhost and connection local set.

@webknjaz
Copy link
Member

So how about adding other parts of the original script here?

@RootenberG RootenberG force-pushed the automating_applications branch from 85514fd to f798047 Compare August 16, 2019 20:44
@@ -0,0 +1,6 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in the playbook instead

inventory Outdated
@@ -0,0 +1,3 @@
[dev-machines]

localhost ansible_connection=local
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So one inventory file should have the host with connection local and the other inventory should point to the VM over SSH.

Copy link

@l1storez l1storez Aug 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, but I need an example,pls

install-apps.yml Outdated
apt_repository:
repo: "deb [arch=amd64] https://packages.microsoft.com/repos/vscode stable main"
state: present
- name: Install vscode depts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Install vscode depts
- name: Install vscode deps

@webknjaz
Copy link
Member

Bump

@webknjaz
Copy link
Member

webknjaz commented Nov 1, 2019

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite apps installation script as an Ansible playbook
3 participants