Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/10 initial config #12

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Bozonych
Copy link
Collaborator

Resolve #10 issues.

@webknjaz
Copy link
Member

@Bozonych your local Git is misconfigured — all the commits here don't use any email that is verified in your GitHub profile. Use git config to fix this.

@webknjaz webknjaz requested a review from igorkruglyak January 27, 2020 17:23
Copy link

@igorkruglyak igorkruglyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix title. It should have change info. For example 'Add basic configuration and info files'.
Add description. For example
" Closes #12

This commit includes the basic configuration and info files:
README.md
LICENSE.md
.gitignore
.gitattributes"
you can to squash them down into a single commit with the interactive rebasing tool. "git rebase -i"

@webknjaz
Copy link
Member

Well, I wouldn't squash commits in this case because they all seem atomic. But in general, the interactive rebase can help shape the commit messages better.

@webknjaz webknjaz requested a review from slsh1o June 17, 2020 10:08
.gitatributes Show resolved Hide resolved
.gitignore Show resolved Hide resolved
LICENSE.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add basic configuration and info files
4 participants