Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Introduce generator as option for base #3037

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

justinsb
Copy link
Contributor

No description provided.

@justinsb justinsb changed the title Introduce generator as option for base WIP: Introduce generator as option for base Apr 21, 2022
@justinsb
Copy link
Contributor Author

Marking as WIP for discussion. This is intended to address generators (example prior discussion #2528, though I think this only helps with a subset of those use-cases).

@justinsb
Copy link
Contributor Author

This will allow e.g.

apiVersion: porch.kpt.dev/v1alpha1
kind: PackageRevision
metadata:
  namespace: default
  name: "deployment:postgres:v1"
spec:
  packageName: postgres
  revision: v1
  repository: deployment
  tasks:
  - type: clone
    clone:
      generator:
        config:
          apiVersion: fn.kpt.dev/v1alpha1
          kind: RenderHelmChart
          helmCharts:
          - chartArgs:
              name: postgresql
              repo: https://charts.bitnami.com/bitnami
            templateOptions:
              values:
                valuesInline:
                  postgresqlDataDir: /kpt/postgresql/data
  - type: eval
    eval:
      image: gcr.io/kpt-fn/set-labels:v0.1.5
      configMap:
        bucket-label: bucket-label-value
        another-label: another-label-value

@justinsb
Copy link
Contributor Author

I uploaded a bit more in #3041 which shows how we could discover the function for a CRD

@justinsb justinsb requested review from martinmaly and droot April 21, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant