-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps #4181
Update deps #4181
Conversation
Signed-off-by: Minna Howell <minnah@google.com>
Signed-off-by: Minna Howell <minnah@google.com>
Signed-off-by: Minna Howell <minnah@google.com>
Signed-off-by: Minna Howell <minnah@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this PR, it looks great! We really need the dependency updates over in Nephio.
/approve
@@ -29,7 +29,7 @@ func NewCommand(ctx context.Context, version string) *cobra.Command { | |||
Use: "rollouts", | |||
Short: "rollouts", | |||
Long: "rollouts", | |||
RunE: func(cmd *cobra.Command, args []string) error { | |||
RunE: func(cmd *cobra.Command, _ []string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should just turn off this linter, it isn't useful / correct
This PR fixes linter warnings.