Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #4181

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Update deps #4181

merged 7 commits into from
Feb 12, 2025

Conversation

droot
Copy link
Contributor

@droot droot commented Feb 11, 2025

This PR fixes linter warnings.

menahyouyeah and others added 7 commits February 11, 2025 14:18
Signed-off-by: Minna Howell <minnah@google.com>
Signed-off-by: Minna Howell <minnah@google.com>
Signed-off-by: Minna Howell <minnah@google.com>
Signed-off-by: Minna Howell <minnah@google.com>
Signed-off-by: Minna Howell <minnah@google.com>
Signed-off-by: Minna Howell <minnah@google.com>
Copy link

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this PR, it looks great! We really need the dependency updates over in Nephio.

/approve

@@ -29,7 +29,7 @@ func NewCommand(ctx context.Context, version string) *cobra.Command {
Use: "rollouts",
Short: "rollouts",
Long: "rollouts",
RunE: func(cmd *cobra.Command, args []string) error {
RunE: func(cmd *cobra.Command, _ []string) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should just turn off this linter, it isn't useful / correct

@justinsb justinsb merged commit 39d7233 into kptdev:main Feb 12, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants