Skip to content

Commit

Permalink
[Security Solution] Remove a data fetching hook from the add to timel…
Browse files Browse the repository at this point in the history
…ine action component (elastic#124331)

* Fetch alert ecs data in actions.tsx and not a hook in every table row

* Add error handling and tests for theshold timelines

* Fix bad merge

* Remove unused imports

* Actually remove unused file

* Remove usage of alertIds and dead code from cases

* Add basic sanity tests that ensure no extra network calls are being made

* Remove unused operator

* Remove unused imports

* Remove unused mock

(cherry picked from commit e312c36)
  • Loading branch information
kqualters-elastic committed Feb 8, 2022
1 parent 9db4880 commit d20de8c
Show file tree
Hide file tree
Showing 19 changed files with 1,099 additions and 239 deletions.
2 changes: 0 additions & 2 deletions x-pack/plugins/cases/public/components/__mock__/timeline.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ export const timelineIntegrationMock = {
useInsertTimeline: jest.fn(),
},
ui: {
renderInvestigateInTimelineActionComponent: () =>
mockTimelineComponent('investigate-in-timeline'),
renderTimelineDetailsPanel: () => mockTimelineComponent('timeline-details-panel'),
},
};
Expand Down
Loading

0 comments on commit d20de8c

Please sign in to comment.