Break up actions #54
Break up actions #54
Conversation
…d other that builds and publishes the wheel
…hrough loops or cases that end up defining variables before being called
| @@ -916,7 +921,7 @@ def calcAndAppendStatValDiplo( | |||
| - statVals["pi"][instanceIndex][subWinIndex] | |||
| ) | |||
| elif statName == "HapCount": | |||
| statVals[statName][instanceIndex].append(len(hapsInSubWin.distinct())) | |||
| statVals[statName][instanceIndex].append(len(genosInSubWin.distinct())) | |||
There was a problem hiding this comment.
hey @bruce-edelman -- slightly worried about this change? does this not throw off the Haplotype stuff?
There was a problem hiding this comment.
Ah, I may have been confused but looking at the code the Haplo/diplo functions seem to be split and each called when specifying haplo or diplo modes. In the haplo version there is the variable hapsInSubWin provided but in the diplo version of the same function there isn't. So that means that this if statement must never be true otherwise there would be undefined variable errors.
I had (maybe overconfidently) assumed that this function maybe was copied from the haplo version and this variable was meant to be genosInSubWin
There was a problem hiding this comment.
Since it appears that maybe the "HapCount" stat won't ever actually be called for the diplo version of the calculating the stats then maybe we can just remove it ?
Break up actions into one that does linting and tests python build and other that builds and publishes the wheel
Idea is to have the action that does linting and tests that the python package builds correctly run on every push on every branch while the building and publishing the wheels only runs when a change into master occurs.
One thing to think about is the PyPI wheel publishing will ALWAYS fail if the version number was not bumped as we cannot publish a wheel with the same version as wheels previously published to PyPI
This means any PR that has meaningful changes that we want to immediately propagate to PyPI versions of diploshic MUST include a bumped version number