Ensure reauthenticate calls exec again #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
==========================================
+ Coverage 95.06% 95.08% +0.02%
==========================================
Files 27 27
Lines 2875 2887 +12
==========================================
+ Hits 2733 2745 +12
Misses 142 142 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KubeAuth.serverwas being used to store both the user specifiedurlkwarg and also the url loaded from the kube config.When loading the kubeconfig we check that the server hasn't been set because we don't want to overwrite a url set by the user. However after the first authentication from kubeconfig that attribute is set, so when we call reauthenticate it looks like a user has specified the url and we never refresh it, so we aren't actually reauthenticating at all.
This PR creates a new
_urlattribute to store the user specified url which allows us to differentiate between them.Updated a couple of tests to ensure that a user specified URL doesn't get overwritten, but a kubectl specified url (and other attributes) get reloaded when we reauthenticate.
Closes #306