Ensure kind and apiVersion are always included in raw specs
#401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #401 +/- ##
==========================================
+ Coverage 94.61% 95.28% +0.66%
==========================================
Files 29 29
Lines 3141 3565 +424
==========================================
+ Hits 2972 3397 +425
+ Misses 169 168 -1 ☔ View full report in Codecov by Sentry. |
leelavg
reviewed
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #400
It seems that when creating custom resources Kubernetes always validates that the
kindandapiVersionfields are included in the spec. This isn't true for core objects and these values can be omitted and we've always made the assumption that this was true for all objects.This PR ensures that those fields are always included in the raw spec.