Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run mypy on tests #492

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Sep 16, 2024

In order to work on #491 we are going to need to be able to test our type annotations. Currently tests are excluded from mypy. This PR adds them back in again.

There were a few failures, many related to the sync API annotations highlighted in #491. For now I've just removed the annotation from the test signature so that mypy skips as we do not enforce strict type checking yet (xref #428).

This PR should merge cleanly with no mypy failures, but will allow us to gradually introduce typing into the tests and therefore test the types.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.19%. Comparing base (87063fc) to head (f13d7e0).
Report is 114 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
+ Coverage   94.61%   95.19%   +0.57%     
==========================================
  Files          29       30       +1     
  Lines        3141     3973     +832     
==========================================
+ Hits         2972     3782     +810     
- Misses        169      191      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit ee85864 into kr8s-org:main Sep 16, 2024
12 checks passed
@jacobtomlinson jacobtomlinson deleted the mypy-tests branch September 16, 2024 16:31
@jacobtomlinson jacobtomlinson restored the mypy-tests branch September 16, 2024 16:33
@jacobtomlinson jacobtomlinson deleted the mypy-tests branch September 17, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant