Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubectl-ng cordon/uncordon #500

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

jacobtomlinson
Copy link
Member

Implemented kubectl-ng cordon NODE and kubectl-ng uncordon NODE.

Also found a typing issue with the return type from APIObject.get(). Updated to use the Self type instead.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.17%. Comparing base (87063fc) to head (0a92d7a).
Report is 121 commits behind head on main.

Files with missing lines Patch % Lines
kr8s/_objects.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
+ Coverage   94.61%   95.17%   +0.55%     
==========================================
  Files          29       30       +1     
  Lines        3141     3978     +837     
==========================================
+ Hits         2972     3786     +814     
- Misses        169      192      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit 967b931 into kr8s-org:main Oct 1, 2024
20 checks passed
@jacobtomlinson jacobtomlinson deleted the kng-cordon branch October 1, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant