Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move off hardcoded plural forms #298

Open
turtlegarden opened this issue Oct 22, 2024 · 3 comments
Open

Move off hardcoded plural forms #298

turtlegarden opened this issue Oct 22, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@turtlegarden
Copy link
Contributor

turtlegarden commented Oct 22, 2024

Is your feature request related to a problem? Please describe.

When I was translating the app, I found that there were various strings with hardcoded singular and plural forms. This can be problematic for languages with e.g. a dual form (for 2 games) and a plural form (3 or more) as well as the singular

Describe the solution you'd like

Usage of ngettext may be a good way to resolve this problem.

Additional context

It might also be nice to add a translator-credits in the About window :) If wanted I can work on these changes and submit a pull request with updated PO files, but I think merging translations from Weblate first would be best.

@turtlegarden turtlegarden added the enhancement New feature or request label Oct 22, 2024
@kra-mo
Copy link
Owner

kra-mo commented Oct 24, 2024

Yeah, this makes sense. Translation credit is already there, libadwaita shows it conditionally based on the language someone is using the app in ^^

I would appreciate a pull request for ngettext, thank you :)

@kra-mo
Copy link
Owner

kra-mo commented Oct 24, 2024

And I merged Weblate

@turtlegarden
Copy link
Contributor Author

Awesome, I'll work on that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants