Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 [FEAT] Decrease navbar height when the terminal is zoomed in #76

Closed
enderprism opened this issue Feb 5, 2024 · 7 comments
Closed
Labels
enhancement New feature or request

Comments

@enderprism
Copy link

enderprism commented Feb 5, 2024

Is your feature request related to a problem? 😢 Please describe.

I zoom in my terminal emulator to make the words easier to read (and to make it closer to Monkeytype). I know having separate font sizes for the words and other TUI elements isn't possible since we're in a terminal.

image
Small text

image
The text is the right size but the navbar is really tall

Describe the solution you'd like 🤔

Make a small version of the logo and decrease the navbar height when the terminal is zoomed in (aka few columns).

Describe alternatives you've considered 🧐

Don't zoom in, or live with the tall header

Additional context 📝

Operating system

EndeavourOS

Terminal emulator

Konsole

Smassh version

smassh --version crashes

I just noticed another bug wow

$ smassh --version
Traceback (most recent call last):
  File "smassh.py", line 2, in <module>
  File "click/core.py", line 1157, in __call__
  File "click/core.py", line 1078, in main
  File "click/core.py", line 1666, in invoke
  File "click/core.py", line 1434, in invoke
  File "click/core.py", line 783, in invoke
  File "click/decorators.py", line 33, in new_func
  File "smassh/__init__.py", line 20, in main
  File "importlib/metadata/__init__.py", line 996, in version
  File "importlib/metadata/__init__.py", line 969, in distribution
  File "importlib/metadata/__init__.py", line 548, in from_name
importlib.metadata.PackageNotFoundError: No package metadata was found for smassh
[223112] Failed to execute script 'smassh' due to unhandled exception!

smassh AUR package version: 3.0.3-1

@enderprism enderprism added the enhancement New feature or request label Feb 5, 2024
@kraanzu
Copy link
Owner

kraanzu commented Feb 6, 2024

I see. Makes sense!

Ah yes, I need to fix the versioning issue for binary packages. I haven't found any good solution yet so I'm thinking of hardcoding it. I will push a fix! :)

@kraanzu
Copy link
Owner

kraanzu commented Feb 8, 2024

Hey @enderprism, I've been trying to implement this thingy and I have a good POC now.
what do you think? Is it similar to what you suggested?

Also, I think I should hide hide all the unnecessary things when the typing starts :)

Before:

image

After:

after

@enderprism
Copy link
Author

it looks exactly like i wanted! maybe still make the header hand some margin at the top and bottom (1 line only's good) because it looks a bit cramped
or maybe add an option to add additional navbar height when zoomed in? i havent tested it yet so i can't tell

@kraanzu
Copy link
Owner

kraanzu commented Feb 8, 2024

it looks a bit cramped

I agree. But I think it might be due to the background color as well, Maybe I can get rid of that (but this seems too odd)

i haven't tested it yet so i can't tell

Right. I'll push it to dev branch.
How did you install it?

@kraanzu
Copy link
Owner

kraanzu commented Feb 9, 2024

Hey @enderprism !

Ok here's the new one:

image

I'm not sure when to resize the bar. Currently, it resizes when the number of rows in the terminal screen is 30
That's 1:6 to the terminal or 1:5 compared to the typing space

@enderprism
Copy link
Author

i'll try it asap

Copy link

Did we solve your problem?

Glad we could help!
Don't forget to star the repository!
@kraanzu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants