[BUG] Division by zero

[yyolk]

Describe the bug 🐛

The application panics with ZeroDivisionError when calculating the accuracy on a new test when the first character is erased.

╭──────────────────────────────────────────────────────────────────────────────────────────────────────────────────── Traceback (most recent call last) ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ /Users/yolk/Library/Application Support/pipx/venvs/smassh/lib/python3.12/site-packages/smassh/ui/widgets/typing/space.py:153 in check_restrictions                                                                                                                         │
│                                                                                                                                                                                                                                                                            │
│   150 │   │   │   return                                                                       ╭────── locals ───────╮                                                                                                                                                     │
│   151 │   │                                                                                    │ min_speed = 3       │                                                                                                                                                     │
│   152 │   │   if min_speed := config_parser.get("min_speed"):                                  │      self = Space() │                                                                                                                                                     │
│ ❱ 153 │   │   │   wpm = self.tracker.stats.wpm                                                 ╰─────────────────────╯                                                                                                                                                     │
│   154 │   │   │   if wpm < min_speed:                                                                                                                                                                                                                                      │
│   155 │   │   │   │   return self.finish_typing()                                                                                                                                                                                                                          │
│   156                                                                                                                                                                                                                                                                      │
│                                                                                                                                                                                                                                                                            │
│ /Users/yolk/Library/Application Support/pipx/venvs/smassh/lib/python3.12/site-packages/smassh/src/stats_tracker.py:116 in wpm                                                                                                                                              │
│                                                                                                                                                                                                                                                                            │
│   113 │                                                                                        ╭─────────────────────────────── locals ───────────────────────────────╮                                                                                                    │
│   114 │   @property                                                                            │ self = <smassh.src.stats_tracker.StatsTracker object at 0x1066ae120> │                                                                                                    │
│   115 │   def wpm(self) -> int:                                                                ╰──────────────────────────────────────────────────────────────────────╯                                                                                                    │
│ ❱ 116 │   │   return round(self.raw_wpm * (self.accuracy / 100))                                                                                                                                                                                                           │
│   117 │                                                                                                                                                                                                                                                                    │
│   118 │   @property                                                                                                                                                                                                                                                        │
│   119 │   def correct(self) -> int:                                                                                                                                                                                                                                        │
│                                                                                                                                                                                                                                                                            │
│ /Users/yolk/Library/Application Support/pipx/venvs/smassh/lib/python3.12/site-packages/smassh/src/stats_tracker.py:111 in accuracy                                                                                                                                         │
│                                                                                                                                                                                                                                                                            │
│   108 │                                                                                        ╭─────────────────────────────── locals ───────────────────────────────╮                                                                                                    │
│   109 │   @property                                                                            │ self = <smassh.src.stats_tracker.StatsTracker object at 0x1066ae120> │                                                                                                    │
│   110 │   def accuracy(self) -> int:                                                           ╰──────────────────────────────────────────────────────────────────────╯                                                                                                    │
│ ❱ 111 │   │   accuracy = (self.correct / (self.correct + self.incorrect)) * 100                                                                                                                                                                                            │
│   112 │   │   return round(accuracy)                                                                                                                                                                                                                                       │
│   113 │                                                                                                                                                                                                                                                                    │
│   114 │   @property                                                                                                                                                                                                                                                        │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

To Reproduce 🐣

1. Start typing in a new test after launching smassh
2. You can type one or more characters, the character doesn't need to be accurate.
3. Erase up to and including the first character.
4. When you erase the first character the application will quit with ZeroDivisionError

Expected behavior 🤔

The application doesn't crash when trying to erase the first character.

The statistics account for the first character being erased.

Maybe the WPM calculation accounts for all characters typed at the start of the session; where erased characters aren't subtracted from the overall calculation.

Screenshots 🧐

I couldn't capture screenshots, but I was able to make a video recording.

smassh-division-by-zero.mov

Your operating system name

Mac OS

Your operating system version

Sonoma 14.4.1

Additional context 📝

If I set the Min Speed to 0 in settings, I cannot cause the application to crash with ZeroDivisionError using the steps above.

[eklairs]

Hey @yyolk!

This bug will be fixed in the next release!

If you are having this bug, again and again, you can install the fixed version from the master branch with:

pip install git+https://github.com/kraanzu/smassh.git

[kraanzu]

Should be fixed now. Please re-open if the issue still persists

[github-actions]

Did we solve your problem?

Glad we could help!
Don't forget to star the repository!
– @kraanzu