Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add 2 second delay before ending the test (#75) #80

Merged
merged 2 commits into from
Feb 9, 2024
Merged

feat: Add 2 second delay before ending the test (#75) #80

merged 2 commits into from
Feb 9, 2024

Conversation

eklairs
Copy link
Collaborator

@eklairs eklairs commented Feb 9, 2024

Adds a 2 second delay before ending the test due to min setting restriction

Closes #75

@eklairs eklairs requested a review from kraanzu February 9, 2024 12:01
kraanzu
kraanzu approved these changes Feb 9, 2024
View reviewed changes
Copy link
Owner

@kraanzu kraanzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kraanzu
Copy link
Owner

kraanzu commented Feb 9, 2024 •
edited
Loading

Please update the CHANGELOG as well :)

@eklairs eklairs requested a review from kraanzu February 9, 2024 12:05
kraanzu
kraanzu requested changes Feb 9, 2024
View reviewed changes
Copy link
Owner

@kraanzu kraanzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect Issue man :-)

@kraanzu kraanzu merged commit b394f6c into kraanzu:develop Feb 9, 2024
2 checks passed
@eklairs eklairs mentioned this pull request Feb 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraanzu kraanzu kraanzu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eklairs @kraanzu