Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: key events to settings after confirm" to fix the typing issue #83

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Revert "fix: key events to settings after confirm" to fix the typing issue #83

merged 1 commit into from
Mar 15, 2024

Conversation

jaxvanyang
Copy link
Contributor

@jaxvanyang jaxvanyang commented Mar 14, 2024

After doing git bisect, I found 7efb866 is the first bad commit. Then I reverted it, and the typing issue is gone.

I don't really know what this commit does, I just want to let you guys know reverting it helps me. If more modification is needed, you can create another PR. I don't know much about the TUI stuff.

Close #82.

@kraanzu
Copy link
Owner

kraanzu commented Mar 14, 2024

Hey there! I think this commit was to fix a bug in setting screen ( it did not respond after resetting the settings ) because of confirmation dialogue box. I'll look into this

Thanks for the investigation. Really appreciate it <3

@eliasdorneles
Copy link

I just bumped into the same problem from #82, and this fixed it for me -- thanks 👍

@jaxvanyang
Copy link
Contributor Author

Hey there! I think this commit was to fix a bug in setting screen ( it did not respond after resetting the settings ) because of confirmation dialogue box. I'll look into this

Setting works fine with or without this revert on my machine. However the reset button seems to only work at the first time -- turn on blind mode, reset, this works, but not reset when do it again. This is also true with or without this revert.

@kraanzu
Copy link
Owner

kraanzu commented Mar 15, 2024

Ok I found out that for some reason, typing screen would get focused after confirmation screen for reset
I'll push a fix for that. Thanks for your contribution @jaxvanyang !

Have a great day :)

@kraanzu kraanzu merged commit 693c1e1 into kraanzu:develop Mar 15, 2024
2 checks passed
@jaxvanyang jaxvanyang deleted the fix/typing branch March 16, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants