Minor OpenGL Dark Overlay Fix #557
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain the problem further? |
This is the easiest way I can explain the issue: |
|
Alright, I understand now. |
andrikpowell
force-pushed
the
opengl-overlay-fix
branch
from
2fc774b to
767a41e
Compare
Should be good now 👍 |
Pedro-Beirao
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to get everything ready in the last big PR, but apparently I missed something.
During the last PR, I found and fixed an issue where the dark overlay would actually become inverted when the Invulnerability effect was on.
However my fix accidently made it so that the overlay ignored screen effects (red pain screen, yellow item screen). So this PR allows those effects to show on the overlay, just as it does on Software.
Let me know if there's a better way to simplify this code, because it seems a bit messier than I'd like, but this is the only way I could get it to not invert either the automap or menu overlay.