Fix assemblies only being publicized if a Type has been publicized #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 24, 2023 21:53
An assembly is currently marked as publicized only if one of its Types changes from non-public to public. This means that specificly publicizing e.g. a non-public field in an already-public Type isn't marked as a modified assembly, in which case no publicized assembly is saved to disk. This fix makes it so that any member being publicized marks the assembly as modified and saved to disk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An assembly is currently marked as publicized only if one of its
Typeschanges from non-public to public. In the case of publicizing e.g. a private field in a Type that is already public makes the task resolve the Type as unmodified, and if that field is the only publicized member in the assembly the entire assembly resolves as unmodified.This fix makes it so that any member being publicized marks the assembly as modified and saved to disk.