Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bubble、selection sort with ruby code #1138

Closed

Conversation

junminhong
Copy link
Contributor

@junminhong junminhong commented Mar 14, 2024

If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:

  • This PR represents the translation of a single, complete document, or contains only bug fixes.
  • The translation accurately conveys the original meaning and intent of the Chinese version. If deviations exist, I have provided explanatory comments to clarify the reasons.

If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist:

  • I have thoroughly reviewed the code, focusing on its formatting, comments, indentation, and file headers.
  • I have confirmed that the code execution outputs are consistent with those produced by the reference code (Python or Java).
  • The code is designed to be compatible on standard operating systems, including Windows, macOS, and Ubuntu.

@junminhong junminhong marked this pull request as ready for review March 14, 2024 16:26
@krahets
Copy link
Owner

krahets commented Mar 14, 2024

Hi @junminhong , thanks for the PR. Some issues to be addressed:

  1. We use simplified Chinese.
  2. The algorithm implementation not variable names is not consistent with the reference language(Python or Java).
  3. Test cases are missing.
  4. We should use different comment formats for the headings of functions, classes, etc.

Please carefully read the contribution guidelines #15 before submitting the PR. Here is an example #1098

@krahets krahets closed this Mar 14, 2024
@junminhong
Copy link
Contributor Author

ok, thank you for reviewing my PR

I will solve the problem you mentioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants