Add JS for chapter of computational complexity #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
justin-tse
reviewed
Dec 15, 2022
There was a problem hiding this comment.
Hi! @gyt95 Thanks for the contribution! This PR will keep open waiting for the space_time_tradeoff.md and leetcode_two_sum.js update. There are some things that need you to update this PR:
- You didn't use ';' at the end of every line in this PR. Could you update them to match other JS codes, at the end of every line use ';'.
- Our repositories' indentation style is 4 spaces, please update them to match other JS codes.
justin-tse
reviewed
Dec 15, 2022
There was a problem hiding this comment.
Hi!@gyt95 The code should have a test and pass the test, please follow the Java code to make the JS test.
You could see the Contribution Guideline: #15 (comment)
krahets
reviewed
Dec 15, 2022
codes/javascript/chapter_computational_complexity/leetcode_two_sum.js
Outdated
Show resolved
Hide resolved
krahets
reviewed
Dec 16, 2022
codes/javascript/chapter_computational_complexity/leetcode_two_sum.js
Outdated
Show resolved
Hide resolved
justin-tse
reviewed
Dec 16, 2022
There was a problem hiding this comment.
Hi! @gyt95, please update the code and the docs. Thank you for your contribution.
codes/javascript/chapter_computational_complexity/leetcode_two_sum.js
Outdated
Show resolved
Hide resolved
codes/javascript/chapter_computational_complexity/leetcode_two_sum.js
Outdated
Show resolved
Hide resolved
codes/javascript/chapter_computational_complexity/leetcode_two_sum.js
Outdated
Show resolved
Hide resolved
codes/javascript/chapter_computational_complexity/leetcode_two_sum.js
Outdated
Show resolved
Hide resolved
codes/javascript/chapter_computational_complexity/leetcode_two_sum.js
Outdated
Show resolved
Hide resolved
codes/javascript/chapter_computational_complexity/leetcode_two_sum.js
Outdated
Show resolved
Hide resolved
krahets
approved these changes
Dec 16, 2022
52 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.