feat: add ruby code block - merge sort #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @juminhong, please complete the check list. |
krahets
reviewed
Apr 10, 2024
| ### 合并左子数组和右子数组 ### | ||
| def merge(nums, left, mid, right) | ||
| # 左子数组区间为 [left, mid], 右子数组区间为 [mid+1, right] | ||
| # 创建一个临时数组tmp，用于存放合并后的结果 |
There was a problem hiding this comment.
Same as the comment in another PR.
(By the way, submitting your work in only one PR is fine.)
krahets
reviewed
Apr 10, 2024
| ### 归并排序 ### | ||
| def merge_sort(nums, left, right) | ||
| # 终止条件 | ||
| # 当子数组长度为1时终止递归 |
krahets
reviewed
Apr 10, 2024
| j += 1 | ||
| k += 1 | ||
| end | ||
| # 将临时数组tmp中的元素复制回原数组nums的对应区间 |
59 tasks
khoaxuantu
reviewed
Apr 10, 2024
There was a problem hiding this comment.
Hi @junminhong, I just have one small comment, the rest LGTM
Co-authored-by: khoaxuantu <68913255+khoaxuantu@users.noreply.github.com>
khoaxuantu
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Hi @junminhong, could you help me change the code as the following:
Co-authored-by: khoaxuantu <68913255+khoaxuantu@users.noreply.github.com>
Co-authored-by: khoaxuantu <68913255+khoaxuantu@users.noreply.github.com>
Co-authored-by: khoaxuantu <68913255+khoaxuantu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:
If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist:
result screenshot