Add graph_adjacency_matrix for javascript and typescript #355
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Pending for review by @justin-tse |
|
emm... |
| /* 删除顶点 */ | ||
| removeVertex(index) { | ||
| if (index >= this.size()) { | ||
| return; |
There was a problem hiding this comment.
| return; | |
| throw new RangeError("Index Out Of Bounds Exception"); |
There was a problem hiding this comment.
TypeScript has the same problem. Please address them, thank you!
There was a problem hiding this comment.
A question.
why not use return; but use Error
return; isn't equivalent to void?
@krahets @justin-tse
There was a problem hiding this comment.
We should let the user know the operation can not be executed.
If using return, it is better to make the function return the removed Node and return None when the index is out of range.
There was a problem hiding this comment.
OK. I got it.
Thanks for your answer! @krahets
There was a problem hiding this comment.
If the function is only used to throw the error, then we will use type: never.
Otherwise, we will use the remaining type. Because anything | never is anything. So we will use void here.
There was a problem hiding this comment.
thanks @justin-tse
|
OK. I've fixed all. |
If this PR is related to coding or code translation, please read the contribution guideline, fill out the checklist, and paste the console outputs to the PR.