feat(stack_and_queue): add go code. #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
krahets
reviewed
Nov 28, 2022
krahets
reviewed
Nov 28, 2022
| package chapter_stack_and_queue | ||
|
|
||
| import "testing" | ||
|
|
There was a problem hiding this comment.
Testing for the Go built-in stack is required.
krahets
reviewed
Nov 28, 2022
krahets
reviewed
Nov 28, 2022
|
|
||
| package chapter_stack_and_queue | ||
|
|
||
| type Deque interface { |
There was a problem hiding this comment.
Testing for the Go built-in deque is required.
There was a problem hiding this comment.
Do you use interface to reveal the usage of built-in Stack, Queue, and Deque?
I'm wondering if it is the only way as It is not consistent with other languages.
Reanon
force-pushed
the
feature/support-go-chapter-stack-queue
branch
from
dc2e043
to
a554590
Compare
Reanon
changed the title
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.Add testcase & benchmark in stack & queue.