feat(chapter_backtracking): Add js and ts codes for chapter 13.3 #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
justin-tse
reviewed
Aug 2, 2023
There was a problem hiding this comment.
@yuan0221 Thank you for your clean code! Please address the following code.
| /* 回溯算法：子集和 I */ | ||
| function backtrack(state, target, choices, start, res) { | ||
| // 子集和等于 target 时，记录解 | ||
| if (target == 0) { |
There was a problem hiding this comment.
Suggested change
| if (target == 0) { | |
| if (target === 0) { |
There was a problem hiding this comment.
Address with others, in JS and TS, we use === instead of == now.
| console.log(`A = ${JSON.stringify(A)}`); | ||
| console.log(`B = ${JSON.stringify(B)}`); | ||
| console.log(`C = ${JSON.stringify(C)}`); | ||
| solveHanota(A, B, C); |
There was a problem hiding this comment.
Suggested change
| solveHanota(A, B, C); | |
| solveHanota(A, B, C); | |
There was a problem hiding this comment.
Our code basis is Java code, addressed with others.
| } | ||
|
|
||
| /* 构建二叉树 */ | ||
| function buildTree(preorder: number[], inorder: number[]) { |
There was a problem hiding this comment.
Suggested change
| function buildTree(preorder: number[], inorder: number[]) { | |
| function buildTree(preorder: number[], inorder: number[]): TreeNode | null { |
| 0, | ||
| 0, | ||
| inorder.length - 1 | ||
| ) as TreeNode; |
There was a problem hiding this comment.
Suggested change
| ) as TreeNode; | |
| ) |
There was a problem hiding this comment.
I don't think we need to use as here.
|
all done，thx. |
justin-tse
reviewed
Aug 3, 2023
krahets
approved these changes
Aug 3, 2023
This was referenced Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this PR is related to coding or code translation, please fill out the checklist and paste the console outputs to the PR.