Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(computational_complexity/two_sum): add go code #8

Merged
merged 1 commit into from
Nov 25, 2022
Merged

feat(computational_complexity/two_sum): add go code #8

merged 1 commit into from
Nov 25, 2022

Conversation

Reanon
Copy link
Contributor

@Reanon Reanon commented Nov 24, 2022

1.add go code to chapter_computational_complexity

@vercel
Copy link

vercel bot commented Nov 24, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hello-algo ✅ Ready (Inspect) Visit Preview Nov 25, 2022 at 1:15AM (UTC)

krahets
krahets reviewed Nov 24, 2022
View reviewed changes
codes/go/go.mod Outdated Show resolved Hide resolved
krahets
krahets reviewed Nov 24, 2022
View reviewed changes
Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @Reanon for the translation!
There are still some issues needed to be clarified.

@Reanon Reanon force-pushed the docs/support-golang-chapter1 branch from 6e01c23 to 920b3c7 Compare November 25, 2022 01:03
@Reanon
feat(chapter1): add go code to chapter1
09d89dc 
1.add go code to chapter_computational_complexity
2.add go code to space_time_tradeoff.md
3. Indentation of Go code is tab in *.go , 4 spaces in *.md
@Reanon Reanon force-pushed the docs/support-golang-chapter1 branch from 920b3c7 to 09d89dc Compare November 25, 2022 01:15
krahets
krahets approved these changes Nov 25, 2022
View reviewed changes
Copy link
Owner

@krahets krahets left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work. Now merge it.

@krahets krahets merged commit 072890e into krahets:master Nov 25, 2022
@krahets
Copy link
Owner

krahets commented Nov 25, 2022 •
edited
Loading

@Reanon By the way, it is not recommended to use Git's push --force.

Git's push --force is destructive because it unconditionally overwrites the remote repository with whatever you have locally, possibly overwriting any changes that a team member has pushed in the meantime.

@Reanon Reanon deleted the docs/support-golang-chapter1 branch November 25, 2022 05:23
@krahets
Copy link
Owner

krahets commented Nov 25, 2022 •
edited
Loading

This PR is linked with #16

@Reanon
Copy link
Contributor Author

Reanon commented Nov 25, 2022

Git' s push --force is to keep only one commit for clear. GitHub doesn't have the functionality of patches, maybe mutil-commits are better choice. The next PR will not use push --force.

@krahets krahets added code Code-related and removed enhancement labels Dec 3, 2022
@Reanon Reanon changed the title feat(chapter1): add go code to chapter1 feat(computational_complexity/two_sum): add go code. Jan 8, 2023
@Reanon Reanon mentioned this pull request Jan 8, 2023
Closed
36 tasks
@Reanon Reanon changed the title feat(computational_complexity/two_sum): add go code. feat(computational_complexity/two_sum): add go code Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krahets krahets krahets approved these changes

Assignees
No one assigned
Labels
code Code-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Reanon @krahets