Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug fixes for array_hash_map.c and counting_sort.c #968

Merged
merged 56 commits into from
Nov 26, 2023
Merged

fix: bug fixes for array_hash_map.c and counting_sort.c #968

merged 56 commits into from
Nov 26, 2023

Conversation

Gonglja
Copy link
Contributor

@Gonglja Gonglja commented Nov 26, 2023

If this PR is related to coding or code translation, please fill out the checklist and paste the console outputs to the PR.

  • I've tested the code and ensured the outputs are the same as the outputs of reference code.
  • I've checked the code (formatting, comments, indentation, file header, etc) carefully.
  • The code does not rely on a particular environment or IDE and can be executed on a standard system (Win, macOS, Ubuntu).

Gonglja and others added 30 commits March 18, 2023 20:17
@Gonglja
fix(codes/cpp): Memory leak fix: the space was not freed when pop rem…
cd1cfe9 
…oved the element.
@Gonglja
Merge branch 'krahets:main' into master
53b02c2
@Gonglja
fix(codes/cpp): Fix access error when printArray(arr, 0)
e6efb72
@Gonglja
Merge remote-tracking branch 'origin/master'
2f08dcb
@Gonglja
Merge branch 'krahets:main' into master
68f53fd
@krahets
Update PrintUtil.hpp
b55231a
@krahets
Merge branch 'main' into master
5abf181
@Gonglja
Merge branch 'krahets:main' into master
69e7973
@Gonglja
Merge branch 'krahets:main' into master
c1a6168
@Gonglja
Merge branch 'krahets:main' into master
d875d23
@Gonglja
fix(codes/c): Fix some errors of cmake build
e9a7238
@Gonglja
feat(codes/c): Add hashing_search.c
55fe194
@Gonglja
Merge branch 'krahets:main' into master
75b838e
@Gonglja
Merge branch 'krahets:main' into master
8fef6a6
@Gonglja
Merge branch 'krahets:main' into main
c659519
@Gonglja
styles(codes/c): Modify function description
d7e582b
@Gonglja
styles(codes/c): Modify binary_search.c code style
1fa0e58
@Gonglja
Merge branch 'krahets:main' into main
903d6bd
@Gonglja
Merge branch 'krahets:main' into main
a266334
@Gonglja
fix(codes/c): Fix the problem in binary_tree_bfs.c and the problem th…
11ce50f 
…at the memory is not released.
@Gonglja
Merge branch 'krahets:main' into main
f4d85c6
@Gonglja
Merge branch 'krahets:main' into main
2d79565
@Gonglja
feat: Add preorder_traversal_i_compact.c
0ef4f41
@Gonglja
Merge remote-tracking branch 'refs/remotes/origin/main'
8b44c21
@Gonglja
feat(codes/c): Add head_sort.c
5034e02
@Gonglja
feat(codes/c): Add bucket_sort.c
af533b0
@Gonglja
Merge branch 'krahets:main' into main
265de38
@Gonglja
feat(codes/c): Add binary_search_edge.c
bd2df0b
@Gonglja
fix(codes/c): Add programs that are not managed by cmake (c code)
b68db28
@Gonglja
Merge branches 'main' and 'main' of github.com:Gonglja/hello-algo
728fc23
Gonglja and others added 20 commits July 29, 2023 15:06
@Gonglja
Merge branch 'krahets:main' into main
919a270
@Gonglja
Merge branch 'krahets:main' into main
e55c173
@Gonglja
fix(codes/c): Fix space_complexity.c build error.
22464a3
@Gonglja
feat(codes/c): Add array_binary_tree.c
18f6328
@Gonglja
feat(code/c): Update push_back and pop_back in vector.h
c9753ec
@Gonglja
Merge branch 'krahets:main' into main
ef8df02
@Gonglja
styles(codes/c): Adjust format.
d3f7f9f
@Gonglja
Merge branch 'main' of github.com:Gonglja/hello-algo
1aa166d
@krahets
Merge branch 'main' into main
e62fce3
@Gonglja
Merge remote-tracking branch 'upstream/main'
92fb329
@Gonglja
Merge branch 'krahets:main' into main
c74f7b8
@Gonglja
feat(codes/c): Add interation.c recursion.c simple_hash.c `bin…
b027731 
…ary_search_edge.c` `binary_search_insertion.c` in C codes.
@Gonglja
Merge branch 'krahets:main' into main
17ff669
@Gonglja
Merge branch 'krahets:main' into main
4940590
@Gonglja
fix(mylist.c): Fix insert function in mylist.c
edc31cc 
krahets#32 (comment)
@Gonglja
feat(codes/c): Add binary_search_recur.c
94b7ee6
@Gonglja
Merge branch 'upstream'
10bad07
@Gonglja
Merge branch 'krahets:main' into main
54b3a22
@Gonglja
Merge branch 'krahets:main' into main
0365bc7
@Gonglja
fix(codes/c): Bug fixes in discussion
0281951 
krahets#78
krahets#428
@Gonglja
Copy link
Contributor Author

Gonglja commented Nov 26, 2023

#78
#428

@krahets krahets changed the title Bug fixes in discussion fix: fix the code in array_hash_map.c and counting_sort.c Nov 26, 2023
krahets
krahets approved these changes Nov 26, 2023
View reviewed changes
Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@krahets krahets changed the title fix: fix the code in array_hash_map.c and counting_sort.c fix: bug fixes for array_hash_map.c and counting_sort.c Nov 26, 2023
@krahets krahets added bug Bug fixes code Code-related labels Nov 26, 2023
@krahets krahets merged commit d960c99 into krahets:main Nov 26, 2023
4 checks passed
@krahets
Copy link
Owner

krahets commented Nov 26, 2023

I would recommend you re-fork the repo to make a clearer commit history.

@Gonglja
Copy link
Contributor Author

Gonglja commented Nov 26, 2023 via email

@krahets
Copy link
Owner

krahets commented Nov 26, 2023

@Gonglja I think there should be a Sync button in your fork repository. Just click it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krahets krahets krahets approved these changes

Assignees
No one assigned
Labels
bug Bug fixes code Code-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gonglja @krahets