compiler-rt-sanitizers: Build fixes #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library is now named liborc which leads to conflicts when installing
compiler-rt and compiler-rt-sanitizers in parallel.
Installing compiler-rt-sanitizers-staticdev (17.0.6) on root
* check_data_file_clashes: Package compiler-rt-sanitizers-staticdev wants to install file .../usr/lib/clang/17.0.6/lib/linux/liborc_rt-x86_64.a
But that file is already provided by package * compiler-rt-staticdev
Signed-off-by: Philip Lorenz <philip.lorenz@bmw.de>
When configuring with COMPILER_RT_USE_BUILTINS_LIBRARY=ON, compiler-rt expects the target builtin libraries to be available. Make sure that this really is the case by adding them to DEPENDS. Without the dependency recipe build fails during the configure task | -- Failed to find compiler-rt builtins library for x86_64-poky-linux | CMake Error at .../build/tmp/work-shared/llvm-project-source-17.0.6-r0/git/compiler-rt/cmake/Modules/AddCompilerRT.cmake:281 (message): | Cannot find builtins library for the target architecture | Call Stack (most recent call first): | .../build/tmp/work-shared/llvm-project-source-17.0.6-r0/git/compiler-rt/lib/stats/CMakeLists.txt:23 (add_compiler_rt_runtime) Signed-off-by: Philip Lorenz <philip.lorenz@bmw.de>
kraj
reviewed
Feb 13, 2024
| @@ -15,7 +15,7 @@ LIC_FILES_CHKSUM = "file://compiler-rt/LICENSE.TXT;md5=d846d1d65baf322d4c485d6ee | |||
|
|
|||
| TUNE_CCARGS:remove = "-no-integrated-as" | |||
|
|
|||
| DEPENDS += "ninja-native virtual/crypt" | |||
| DEPENDS += "ninja-native virtual/crypt compiler-rt" | |||
There was a problem hiding this comment.
are you using TC_CXX_RUNTIME = 'gnu' ?
There was a problem hiding this comment.
Yes, I encountered this issue when building with a default Yocto config as provided by oe-init-build-env (so TC_CXX_RUNTIME = "gnu")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building compiler-rt-sanitizers I encountered some build and packaging issues. I am not certain why the missing
compiler-rtdependency was not observed before but the configuration failure is reproducible in a clean Yocto build which merely includes themeta-clanglayer without making any further configuration adaptations.Contributor checklist
Signed-off-byis presentReviewer Guidelines