-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clang: Allow conditional compilation of clangd #912
Conversation
111e6bb
to
f9206c8
Compare
Move common PACKAGECONFIG default values into a dedicated variable and sort values alphabetically (hopefully making it easier to figure out where to add a new value when extending the variable). Signed-off-by: Philip Lorenz <philip.lorenz@bmw.de>
f9206c8
to
3f95af7
Compare
it looks like
|
clangd should not be needed in target builds. Extend PACKAGECONFIG to enable selective disabling and disable it by default for target builds. Signed-off-by: Philip Lorenz <philip.lorenz@bmw.de>
3f95af7
to
09b0224
Compare
My bad... Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@kraj: Are the build logs of the CI run available somewhere (based on the log output it doesn't look like the CI failure is caused by this change but I'd like to make sure)? |
they are right in github actions link above. Click on 'details' |
I meant the detailed logs of the bitbake run (or I am simply failing to find the right link :-)). The logs from https://github.com/kraj/meta-clang/actions/runs/7899722329/attempts/2?pr=912:
sounds like the failure is unrelated to change (but there is a chance that the issue leading up to this would be visible from the bitbake logs). |
thats is bitbake run ( actually runtime logs in qemuarm64 ), however, this failure is known, it happens when more than one qemu instance is running same test case, it happens rarely but happens. I have started another run and see if it goes through. |
clangd should not be needed in target builds. Extend PACKAGECONFIG to
enable selective disabling and disable it by default for target builds.
Additionally, this enables compilation of
clang-native
on Debian "bullseye"hosts where GCC 10 fails to compile clangd with an internal compilation
error.
Contributor checklist
Signed-off-by
is presentReviewer Guidelines