Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced urlpush with sprintf to avoid beginning slash #115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kpelzel
Copy link
Contributor

@kpelzel kpelzel commented Nov 14, 2019

Problem:
When calling .Diff() to compare two nodes, the extensions will contain a leading slash in their url (for example: <nodeid>:/type.googleapis.com/proto.blah/State). This is due to how URLPush() works. This will cause issues with the SME because it filters out any STATE_CHANGE events that contain extensions with a leading slash.

Solution:
I replaced URLPush() with sprintf to just append the extension url to the node id. I didn't do extensive testing on this, but it did fix the issue with the SME filtering out my events.

@kpelzel
Copy link
Contributor Author

kpelzel commented Nov 15, 2019

Feedback:

  • figure out if we want all urls to begin with "/"
  • make sure all url manipulation is happening in util.go

Base automatically changed from master to main March 23, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant