Non-issue : Fixed a minor bug in async streams resume() method

kraken-php · Dec 18, 2016 · 6d8498f · 6d8498f
1 parent 6a48415
commit 6d8498f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/Stream/AsyncStream.php b/src/Stream/AsyncStream.php
@@ -135,17 +135,17 @@ public function pause()
  */
  public function resume()
  {
- if ($this->readable && $this->paused)
+ if (($this->writable || $this->readable) && $this->paused)
  {
  $this->paused = false;
 
- if ($this->readingStarted)
+ if ($this->readable && $this->readingStarted)
  {
  $this->reading = true;
  $this->loop->addReadStream($this->resource, [ $this, 'handleRead' ]);
  }
 
- if ($this->buffer->isEmpty() === false)
+ if ($this->writable && $this->buffer->isEmpty() === false)
  {
  $this->writing = true;
  $this->loop->addWriteStream($this->resource, [ $this, 'handleWrite' ]);

diff --git a/src/Stream/AsyncStreamReader.php b/src/Stream/AsyncStreamReader.php
@@ -111,7 +111,7 @@ public function pause()
  */
  public function resume()
  {
- if ($this->paused)
+ if ($this->readable && $this->paused)
  {
  $this->paused = false;
  if ($this->readingStarted)

diff --git a/src/Stream/AsyncStreamWriter.php b/src/Stream/AsyncStreamWriter.php
@@ -113,7 +113,7 @@ public function pause()
  */
  public function resume()
  {
- if ($this->paused)
+ if ($this->writable && $this->paused)
  {
  $this->paused = false;
  if ($this->buffer->isEmpty() === false)