Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log pump #29

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix log pump #29

wants to merge 8 commits into from

Conversation

kpacha
Copy link
Member

@kpacha kpacha commented Mar 7, 2025

Instead of using a fix sized buffer, go with buffio scanners so no more padding or size limit for the debug messages

kpacha added 3 commits March 7, 2025 18:39
@kpacha
fix deps
9ba0c4c 
Signed-off-by: kpacha <dlopez@krakend.io>
@kpacha
test the runserver and the debug mode
3ab0dee 
Signed-off-by: kpacha <dlopez@krakend.io>
@kpacha
log pumping improved
2dce843 
Signed-off-by: kpacha <dlopez@krakend.io>
@kpacha kpacha requested review from thedae, dhontecillas and taik0 March 7, 2025 17:44
deepsource-autofix bot and others added 5 commits March 7, 2025 17:44
@deepsource-autofix
style: format code with Go fmt and Gofumpt
f376e89 
This commit fixes the style issues introduced in 2dce843 according to the output
from Go fmt and Gofumpt.

Details: #29
@kpacha
upgrade the go version
874710e 
Signed-off-by: kpacha <dlopez@krakend.io>
@kpacha
fix new tests failling after the deps upgrade
9cf5fa9 
Signed-off-by: kpacha <dlopez@krakend.io>
@kpacha
Merge branch 'master' into fix_log_pump
029bc86
@kpacha
fix go.mod
1f568a9 
Signed-off-by: kpacha <dlopez@krakend.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedae thedae Awaiting requested review from thedae

@dhontecillas dhontecillas Awaiting requested review from dhontecillas

@taik0 taik0 Awaiting requested review from taik0

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kpacha