Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase unit test coverage in the utils file chunk2 🧪 #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

borodovisin
Copy link

@borodovisin borodovisin commented Mar 24, 2022

Description

The PR contains the first chunk of unit tests for the util.js file in order to increase the test coverage in the repo.
The util.js file will require a bunch of test cases to avoid huge PRs multiple chunks will be released.

Why are we making these changes?

To increase the coverage gradually.

Caveats

This PR is a little long and hard to review 😿

Accomplishment

At the end of merging this PR will have the 95% of coverage on the util.js file

@borodovisin borodovisin requested a review from a team as a code owner March 24, 2022 23:17
@borodovisin borodovisin changed the title test(utils): increase test coverage final chunkDescription The PR contains the first chunk of unit tests for the util.js file in order to increase the test coverage in the repo. The util.js file will require a bunch of test cases to avoid huge PRs multiple chunks will be released. Why are we making these changes? To increase the coverage gradually. Increase unit test coverage in the utils file chunk2 🧪 Mar 24, 2022
test/tests/util/awayKey.js Outdated Show resolved Hide resolved
@borodovisin borodovisin force-pushed the DTPPSDK-709/utils-test-chunk-2 branch from 68f3b7e to e5a760c Compare March 28, 2022 13:31
Copy link
Member

@wsbrunson wsbrunson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥

@borodovisin borodovisin force-pushed the DTPPSDK-709/utils-test-chunk-2 branch from e5a760c to aa9f6fe Compare April 20, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants