Initializing PassportJS

[nomanurrehman]

I am trying but failing to register PassportJS middleware in the config file. Here is the config file code for meddleware:

// passportjs
"passport": {
   "enabled": true,
   "priority": 92,
   "module": {
      "name": "passport",
      "method": "initialize"
   }
},
// passportjs
"passport": {
   "enabled": true,
   "priority": 93,
   "module": {
      "name": "passport",
      "method": "session"
   }
}

What am I doing wrong ?

[aredridel]

Since passport needs a bit more setup, take a peek at https://github.com/krakenjs/kraken-examples/blob/master/with.passport/config/config.json and particularly https://github.com/krakenjs/kraken-examples/blob/master/with.passport/lib/spec.js

[tlivings]

Are you receiving an error message? Can you post additional details?

[nomanurrehman]

I have actually seen the KrakenJS passport example and how the code is put in there to initialize it with the event hooks but do not you think that is a bit anti-productive to the whole 'middleware in config' idea as that scatters the code a bit ?

There is no way to do it purely using the config file ?

Here is the error:

TypeError: Object #<Object> has no method 'authenticate'
    at Authenticator.session (/home/noman/Projects/NodeJS/FileUploadService/node_modules/passport/lib/authenticator.js:237:15)
    at resolveImpl (/home/noman/Projects/NodeJS/FileUploadService/node_modules/kraken-js/node_modules/meddleware/index.js:98:20)
    at resolve (/home/noman/Projects/NodeJS/FileUploadService/node_modules/kraken-js/node_modules/meddleware/index.js:53:18)
    at register (/home/noman/Projects/NodeJS/FileUploadService/node_modules/kraken-js/node_modules/meddleware/index.js:206:22)
    at Array.forEach (native)
    at Function.onmount (/home/noman/Projects/NodeJS/FileUploadService/node_modules/kraken-js/node_modules/meddleware/index.js:203:14)
    at Function.g (events.js:180:16)
    at Function.emit (events.js:117:20)
    at /home/noman/Projects/NodeJS/FileUploadService/node_modules/express/lib/application.js:196:8
    at Array.forEach (native)

[tlivings]

The vast majority of middleware is configured simply through a single call and these cases are handled. Passport's requirement to not only add middleware, but add strategies to passport itself make a purely configuration driven setup hard. This is just the situation that the middleware event hooks were designed for.

[luizfilipe]

Passport needs the module as scope of factory function how we can see here but this is not able, because of that line.

My thought about this:

return factory.apply(module, args);

[luizfilipe]

@tlivings The strategies can be loaded on an event passport:before or not?

[tlivings]

I don't see why not.

[luizfilipe]

@tlivings I made a two days ago a PR, to improve the problem with this issue, when someone will review the changes?

[aredridel]

Taking a look at that pr now!

[luizfilipe]

@totherik The #29 solves this issue? Thoughts?

[aredridel]

LGTM!

[totherik]

Yep, as far as I can tell #29 solves this.

[luizfilipe]

@totherik When #29 go to npm registry?

[totherik]

Hey sorry @luizfilipe, I'll try to get this published today. Looking like it'll be meddleware@3.0 due to the breaking changes.

[hanric]

Hi, I know it's been a while, but could you explain how this fix works with Passport? Thank you.

[totherik]

My understanding was just that Passport internally depend on instance methods. Due to context not being set correctly the object instance upon which methods were being called was not the correct or expected one.