Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support case when shortstop-handler is deployed as global dependency #19

Merged
merged 1 commit into from
Feb 10, 2022
Merged

support case when shortstop-handler is deployed as global dependency #19

merged 1 commit into from
Feb 10, 2022

Conversation

sumeetkakkar
Copy link
Contributor

include process.cwd() in the module.paths to handle case when shortstop-handler is deployed outside the app's node_modules.

This is to support resolving require:awesomemodule in the below setup.

-                                               -  -  -  -      app-root
  |                                                                   |
   node_modules / shortstop_handlers.      |
                                                                      |
                                                                       node_modules / awesomemodule

include process.cwd() in the module.paths to handle case when shortst…
8ee9eaf 
…op-handler is deployed outside the app's node_modules
@sumeetkakkar sumeetkakkar merged commit 7eb5db3 into krakenjs:master Feb 10, 2022
@sumeetkakkar sumeetkakkar deleted the fix/require-resolution branch February 10, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumarrishav kumarrishav kumarrishav approved these changes

@maxmil7 maxmil7 maxmil7 approved these changes

@grawk grawk Awaiting requested review from grawk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumeetkakkar @maxmil7 @kumarrishav