-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: properly handle render errors in 'react' driver. #335
base: main
Are you sure you want to change the base?
Conversation
This looks great to me, thanks for taking this up! Can you add a couple of tests to verify the new behavior? |
Thanks! I'll try to work on that when I get some free time. |
f038f7e
to
645faac
Compare
Totally, sorry about the poor Windows support. If there are any changes you would like to include to improve cross-compatibility there, I'd be happy to merge them in. |
06ef90e
to
cf61b10
Compare
cf61b10
to
7e05c6c
Compare
When will this be released? Seems like a major issue that is not being taken seriously with the priority it should have. |
a6dbeec
to
f8eeb3e
Compare
22cbfdf
to
c890107
Compare
will this ever be merged? @tmilar @bluepnume |
Ping @tmilar @bluepnume ^^ 🙏 |
With this change, a react component that throws on the
render()
async method, will check first if the component is still mounted, and in that case attempt to rethrow the error inside the React render loop.Fixes #334