Fix/update Windows CI #330
Conversation
The actions/upload-artifacts@v4 ignores hidden folders (unless explicitly told not to), and there is no need for that. Instead we install into a folder outside of the sources.
The latter should bring a considerable performance improvement.
The upload action is picky about "relative paths", so we work around.
|
@realFlowControl, it seems one (or more) of the test cases are flaky on Windows. I had to cancel PHP 8.2 after 30mins, and the previous run cancelled almost all Windows runners. I have no idea why; maybe an issue with the rather old pthreads 3.0.0? (unfortunately, there have been no releases for a couple of years) |
|
I have seen this as well, that sometimes one of the Windows tests is just super slow. Restarting it mostly works ... |
|
Is there anything further I need to do for the artefacts to show up in pecl? |
|
The artifacts for PECL are built and uploaded by the https://github.com/php/php-windows-builder team. I guess they're just busy, and will upload soon. The CI artifacts are just meant for testing purposes. E.g. checking that a bug fix works as expected. |
|
Thanks for the clarification 🙇 |
This should fix the build artifact upload which is broken as of 10e43f1 (sorry, my bad). It should also use the caches of this repository to speed up the setup of the PHP SDK.