Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add building of windows binaries to GitHub releases #336

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

realFlowControl
Copy link
Collaborator

@realFlowControl realFlowControl commented Dec 13, 2024

This PR will add making Windows releases and magically add them to the GitHub release for https://github.com/php/pie to find them. Once this PR is merged and working, we should fully support pie

@realFlowControl realFlowControl force-pushed the florian/windows-build branch 3 times, most recently from 5fd8817 to 248a8de Compare December 13, 2024 11:01
@realFlowControl
Copy link
Collaborator Author

Thanks @cmb69, but it is still not working :-(
What I am trying is to support pie and following this https://github.com/php/pie/blob/main/docs/extension-maintainers.md#automation-of-the-windows-publishing
I guess we could also just use the already existing windows.yml and change the filenames so that they fit the schema that pie needs...
Just hoped it would be easier migrating to what is proposed ...

@cmb69
Copy link
Collaborator

cmb69 commented Dec 13, 2024

@realFlowControl, should use php-windows-builder for release builds by all means for stability reasons (ideally all extensions should use exactly the same dependency versions etc.) For push CI this is not really a concern.

@cmb69
Copy link
Collaborator

cmb69 commented Dec 13, 2024

Not sure if the build log is supposed to be contained in the download artifact, but otherwise this looks quite good now.

@realFlowControl
Copy link
Collaborator Author

Technically CI is green, but all tests are skipped 😱

@cmb69
Copy link
Collaborator

cmb69 commented Dec 13, 2024

Oh, indeed. I guess that pthreads is not found. I'd remove the manual "Fetch dependencies" step (maybe that interferes), and see if it works.

PS: from a quick look at the implementation of php-windows-builder, it looks like it runs php run-tests.php directly (instead of nmake test), so deps\bin\ is not in the PATH.

PPS: I've filed php/php-windows-builder#9. You can verify the hypothesis by adding a test which does not rely on ext-parallel, but merely outputs the PATH, e.g.

--TEST--
Show PATH
--FILE--
<?php
var_dump(getenv("PATH"));
?>
--EXPECT--

@realFlowControl realFlowControl changed the title try windows releases Add building of windows binaries to GitHub releases Dec 17, 2024
@realFlowControl realFlowControl marked this pull request as ready for review January 29, 2025 10:14
realFlowControl and others added 2 commits January 29, 2025 11:16
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
@realFlowControl
Copy link
Collaborator Author

@cmb69 could you do me a favour and check if the binaries produced from the job do work for you?
https://github.com/krakjoe/parallel/actions/runs/13029111249?pr=336
AFAIK you are using PHP on Windows.

@cmb69
Copy link
Collaborator

cmb69 commented Jan 29, 2025

I've only quickly checked the PHP 8.4 x64 build, and couldn't find any issues. However, the download package has a strange structure; the relevant files are in a zip archive inside the downloaded zip, and the build logs are also distributed. It might be necessary to add a release step.

@realFlowControl realFlowControl merged commit c40c2c1 into develop Jan 29, 2025
49 checks passed
@realFlowControl realFlowControl added this to the v1.2.6 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants