-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add building of windows binaries to GitHub releases #336
Conversation
5fd8817
to
248a8de
Compare
248a8de
to
d3b7f82
Compare
Thanks @cmb69, but it is still not working :-( |
@realFlowControl, should use php-windows-builder for release builds by all means for stability reasons (ideally all extensions should use exactly the same dependency versions etc.) For push CI this is not really a concern. |
Not sure if the build log is supposed to be contained in the download artifact, but otherwise this looks quite good now. |
Technically CI is green, but all tests are skipped 😱 |
Oh, indeed. I guess that pthreads is not found. I'd remove the manual "Fetch dependencies" step (maybe that interferes), and see if it works. PS: from a quick look at the implementation of php-windows-builder, it looks like it runs PPS: I've filed php/php-windows-builder#9. You can verify the hypothesis by adding a test which does not rely on ext-parallel, but merely outputs the PATH, e.g.
|
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
0664af2
to
856d8b0
Compare
@cmb69 could you do me a favour and check if the binaries produced from the job do work for you? |
I've only quickly checked the PHP 8.4 x64 build, and couldn't find any issues. However, the download package has a strange structure; the relevant files are in a zip archive inside the downloaded zip, and the build logs are also distributed. It might be necessary to add a release step. |
This PR will add making Windows releases and magically add them to the GitHub release for https://github.com/php/pie to find them. Once this PR is merged and working, we should fully support pie