-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Post Processing Commands #129
base: master
Are you sure you want to change the base?
Conversation
e7e33ab
to
6480733
Compare
Post processing commands can be specified on the command line. These commands are executed after the main command exits and can optionally be passed the exit code from the last process that tini ran. The exit code of the post processing command is the new exit code of tini. Multiple post processing commands can be chained together, with the output of each one getting the exit code of the previous one. Post processing commands inherit the signal mask of the parent tini process (unlike the primary child).
Tests post processing commands and chaining of post-processing commands
Any update on this? |
Ping? |
I'm sorry, I haven't had much free time over the past couple of months to look after personal projects 😢 . I'll take a look as soon as I can, but I can't promise when I might be able to do so. I know this situation can be frustrating; I apologize for that! |
That's alright. Thank you for your time :) |
Honestly, I'm a little confused by this PR -- it seems like this is pushing |
Sure, it is perfectly acceptable to close this PR as inappropriate and I'll just keep maintaining my fork that does this behaviour since I need it. I figured since I put in the effort, I would at least see if upstream was interested :) FWIW, I did look at the other init managers and they didn't do what I needed. The important behaviour in this PR is that the post command inherits tini's signal mask, and therefore is uninterruptable by default (it can of course change that if it wants). I attempted to make this generic enough that it could theoretically be used to replace other functionality in tini. For example, the post-processing commands can easily replace exit code remapping. |
Sure, don't take me as the final word, I'm not a maintainer here, just an
interested/invested party. 😅
|
@krallin is there any chance that we could get some feedback on this PR? Thanks :) |
@krallin still no news? could be nice to see this merged at some point. |
Adds support to tini for implementing post processing commands. These commands can be used to run clean up procedures, or remap exit codes.