doctrine#4295 Restored master, slaves, keepReplica params in MasterSl…

…aveConnection

lib/Doctrine/DBAL/Connections/MasterSlaveConnection.php

@@ -38,21 +38,18 @@ public function __construct(
  $this->deprecated('Params key "master"', '"primary"');
 
  $params['primary'] = $params['master'];
- unset($params['master']);
  }
 
  if (isset($params['slaves'])) {
  $this->deprecated('Params key "slaves"', '"replica"');
 
  $params['replica'] = $params['slaves'];
- unset($params['slaves']);
  }
 
  if (isset($params['keepSlave'])) {
  $this->deprecated('Params key "keepSlave"', '"keepReplica"');
 
  $params['keepReplica'] = $params['keepSlave'];
- unset($params['keepSlave']);
  }
 
  parent::__construct($params, $driver, $config, $eventManager);

tests/Doctrine/Tests/DBAL/Connections/MasterSlaveConnectionTest.php

@@ -0,0 +1,43 @@
+<?php
+
+namespace Doctrine\Tests\DBAL\Connections;
+
+use Doctrine\DBAL\Connections\MasterSlaveConnection;
+use Doctrine\DBAL\Driver;
+use Doctrine\Tests\DbalTestCase;
+
+class MasterSlaveConnectionTest extends DbalTestCase
+{
+ /**
+ * \Doctrine\DBAL\Connection::getParams has been marked @internal as of 2.11.0
+ * This test will be removed in 3.0
+ */
+ public function testConnectionDoesParamsRemainAvailable(): void
+ {
+ $constructionParams = [
+ 'driver' => 'pdo_mysql',
+ 'keepSlave' => true,
+ 'master' => [
+ 'host' => 'master.host',
+ 'user' => 'root',
+ 'password' => 'password',
+ 'port' => '1234',
+ ],
+ 'slaves' => [
+ [
+ 'host' => 'slave1.host',
+ 'user' => 'root',
+ 'password' => 'password',
+ 'port' => '1234',
+ ],
+ ],
+ ];
+
+ $connection = new MasterSlaveConnection($constructionParams, $this->createMock(Driver::class));
+
+ $connectionParams = $connection->getParams();
+ foreach ($constructionParams as $key => $value) {
+ self::assertSame($constructionParams[$key], $value);
+ }
+ }
+}