-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to cats-effect, fs2 3.0.0-M3 builds #80
base: master
Are you sure you want to change the base?
Conversation
f19caed
to
5d5983e
Compare
streamz-converter/src/main/scala/streamz/converter/Converter.scala
Outdated
Show resolved
Hide resolved
I think at this point the main unresolved question is whether CE3 will recommend using |
recommendation from CE team is to create locally, it's cheap https://gitter.im/typelevel/cats-effect-dev?at=5fbbc54afe857d71dc8dad83 Edit: that won't work, as I don't think changing the signature to return |
WDYT about wrapping all ops in a trait and creating a dispatcher as part of that? Then all the methods inside could hopefully return raw streams/sinks (with no constraints, which is a good thing anyway)? |
I think it's reasonable, but I wasn't sure. Some thoughts in #84 |
Anything that is blocking this currently? I have been using @Daenyth code is isolation. Seems to do solve my issue since I am using CE3. |
I haven't had time to work on this lately, and I'm no longer using it at work. I'd say this is probably "good enough" to push just to have something out, but I don't have bandwidth to roll it out |
Upgrade to fs2 3.2.4 and cats-effect 3.3.1
This adds some minor api cleanup as well. It shouldn't affect anyone downstream too badly, I think