forked from jupyterlab/jupyterlab
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance and caching tests for stdout/stderr #138
Draft
krassowski
wants to merge
17
commits into
main
Choose a base branch
from
fix/faster-std-rendering
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lab#16852) * Run CI on Python 3.9 and 3.13 (drop 3.8 from testing matrix) * Bump `setuptools` to fix minimum versions test. For reference it was: The conflict is caused by: The user requested setuptools>=40.8.0 The user requested (constraint) setuptools==40.1.0 * Try `setuptools>=40.9.0` * Setuptools 41.1.0 is minimum that works with Python 3.9 See https://github.com/pypa/setuptools/blob/e622859e278e1751175ded6f8f41ea3de06e4855/NEWS.rst#v4110
…g `RTC:`) (jupyterlab#16988) * Fix FileBrowserModel.onFileChanged * Fix * Add back prefix before comparing paths * Add test
* Fix handling of carriage return in output streams * Lint
…terlab into fix/faster-std-rendering
Co-authored-by: M Bussonnier <bussonniermatthias@gmail.com>
* Bump httpx v0.28.0 * Use `~=` for httpx --------- Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Design System CSS
documentation
Improvements or additions to documentation
pkg:filebrowser
pkg:notebook
pkg:outputarea
pkg:rendermime
pkg:ui-components
tag:CSS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Code changes
Adds caching for results on the
linkify
method which is the most expensive step of rendering large errors and standard outputs.User-facing changes
Faster stdout
Faster stderr
I had to increase
--ServerApp.iopub_msg_rate_limit
to10000
as the stream was faster thanjupyter-server
was allowing for ("IOPub message rate exceeded").Backwards-incompatible changes