Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement notched box plots, closes #2286 #1

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Implement notched box plots, closes #2286 #1

wants to merge 12 commits into from

Commits on Jan 27, 2018

  1. Implement notched box plots, closes plotly#2286

    @krassowski
    krassowski committed Jan 27, 2018
    Configuration menu
    Copy the full SHA
    a234668 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2018

  1. Address 3/4 of @alexcjohnson's comments on notches

    @krassowski
    krassowski committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    144989c View commit details
    Browse the repository at this point in the history

  2. Unbind VAO in gl-surface3d

    @dy
    dy committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    f1cfa60 View commit details
    Browse the repository at this point in the history

  3. Bump gl-surface3d

    @dy
    dy committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    7216fda View commit details
    Browse the repository at this point in the history

  4. Update mocks

    @dy
    dy committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    8456f95 View commit details
    Browse the repository at this point in the history

  5. Remove gl-shader direct dep

    @dy
    dy committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    d3ebe97 View commit details
    Browse the repository at this point in the history

  6. Merge pull request plotly#2306 from plotly/unlock-shader-fix 

    Unbind VAO in gl-surface3d
    @dy
    dy authored Jan 29, 2018
    Configuration menu
    Copy the full SHA
    c842e99 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2018

  1. Merge branch 'master' into notched_box_plot

    @krassowski
    krassowski committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    0eb99e0 View commit details
    Browse the repository at this point in the history

  2. Implement 'smarter' notched/notchwidth default 

    I deliberately removed `"notched":true` in one of test
box traces so it is (indirectly) tested
    @krassowski
    krassowski committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    453d329 View commit details
    Browse the repository at this point in the history

  3. Change notchwidth convention to Matlab, d=0.25

    @krassowski
    krassowski committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    e621d0f View commit details
    Browse the repository at this point in the history

  4. Set notch width range to (0, 0.5) instead of (0,1) 

    presumably for better consistency with Matlab
    @krassowski
    krassowski committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    4ffc52b View commit details
    Browse the repository at this point in the history

  5. Update test images for notched box plots

    @krassowski
    krassowski committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    8dde2d2 View commit details
    Browse the repository at this point in the history